Merged
Conversation
Move FileHandle padding to high bits so idx/generation/checksum fit within f64 exact integer range (48 bits), preventing silent handle corruption when round-tripping through LuaJIT numbers. Replace non-atomic worker_thread null-signaling with atomic worker_done flag to eliminate data race between worker and join threads. Replace std.debug.assert in open_file response handler with explicit error return that survives ReleaseFast. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
errdefer was dead code — moduleExec returns c_int, not an error union, so the deferred cleanup never fired. Replace with explicit moduleClear calls on each failure path after data_loader_type is allocated. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
zig build test -Doptimize=Debugzig build testzig build python-bindings -Doptimize=ReleaseSafePYTHONPATH=python/src uv run --with pytest python -m pytest python/tests/test_limited_abi.py -qPYTHONPATH=python/src uv run --with pytest python -m pytest python/tests/test_dataloader.py -quv run --with build --with setuptools --with wheel python -m build --wheel --no-isolation python/