[pull] main from containerd:main#294
Merged
pull[bot] merged 3 commits intomeonBot:mainfrom Apr 5, 2026
Merged
Conversation
digest.FromBytes always uses the canonical (sha256) algorithm, so descriptors using other algorithms (e.g. sha512) would never match on the embedded data path, falling through to the provider. Use desc.Digest.Algorithm().FromBytes() to correctly verify data against whatever algorithm the descriptor specifies. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
newFakeImage used digest.NewDigestFromBytes which hex-encodes the raw bytes rather than hashing them, producing a digest with an invalid length. This was previously harmless since the embedded data path in content.ReadBlob never matched, but now that the digest is validated before use, the invalid digest causes an error. Use digest.Canonical.FromBytes which correctly hashes the content. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
content: use descriptor digest algorithm instead of assuming sha256
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )