fix: only use manual conversion for DELETE with content#269
Open
augustoccesar wants to merge 2 commits intomainfrom
Open
fix: only use manual conversion for DELETE with content#269augustoccesar wants to merge 2 commits intomainfrom
augustoccesar wants to merge 2 commits intomainfrom
Conversation
### Description On #263 we changed the conversion of the request from the internal try_into from workers-rs for a manual one to be able to proxy DELETE requests with body. This caused the performance issues reported and with a proposed fix on #268. The changes on #268 however re-introduced the original issue that #263 was attempting to fix, as in it's core, it is what the `try_into` does. As a middle ground, this PR proposes a workaround for the DELETE with body without compromising the performance of other requests.
charlottea98
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On #263 we changed the conversion of the request from the internal try_into from workers-rs for a manual one to be able to proxy DELETE requests with body. This caused the performance issues reported and with a proposed fix on #268.
The changes on #268 however re-introduced the original issue that #263 was attempting to fix, as in it's core, it is what the
try_intofor the Request does.As a middle ground, this PR proposes a temporary workaround for the DELETE with body without compromising the performance of other requests.