⚡ Bolt: Parallelize sources JAR location#111
⚡ Bolt: Parallelize sources JAR location#111google-labs-jules[bot] wants to merge 1 commit intomainfrom
Conversation
…ance. This involved using `parallelStream()` in `SourcesJarLocator` and switching `mURLCache` and `GraphMemoizator` to `ConcurrentHashMap`. These changes address the bottleneck caused by sequential HEAD requests, resulting in significantly faster execution. You can verify the improvements by running `bazel test //resolver:sources_locator_test`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR improves performance by parallelizing the source JAR location process.
Changes:
SourcesJarLocator.fillSourcesAttributeto useparallelStream(). This allows concurrent HEAD requests to Maven repositories to check for the existence of source JARs, which is a major bottleneck in sequential execution.SourcesJarLocator.mURLCachetoConcurrentHashMapto support concurrent access.GraphMemoizatorto useConcurrentHashMapandcomputeIfAbsentto ensure atomicity and thread safety for the memoization cache.This change is safe as
GraphMemoizatorandSourcesJarLocatorare now thread-safe, andHttpURLConnectioninstances are created per request (viaConnectionFactorywhich opens new connections).PR created automatically by Jules for task 9088058870112736945 started by @menny