This repository was archived by the owner on Oct 8, 2023. It is now read-only.
Add message about blank domain input box and mouseover for remember m…#48
Open
Nikolay-Pomytkin wants to merge 4 commits intomasterfrom
Open
Add message about blank domain input box and mouseover for remember m…#48Nikolay-Pomytkin wants to merge 4 commits intomasterfrom
Nikolay-Pomytkin wants to merge 4 commits intomasterfrom
Conversation
maclover7
suggested changes
Nov 4, 2016
Contributor
maclover7
left a comment
maclover7
left a comment
There was a problem hiding this comment.
Can we use a "tooltip" or just stick with the text below the form field? It's a little confusing to have both; let's try and standardize on one of them.
Collaborator
Author
|
I'll change the Remember me tooltip to text below the form field |
maclover7
suggested changes
Nov 5, 2016
views/index.erb
Outdated
| </div> | ||
| <div class="col-md-8 col-xs-offset-1 col-md-offset-1 col-xs-8"> | ||
| <input type="text" class="form-control" name="ps_url" placeholder="ps2.millburn.org"> | ||
| <div style="color: #aeb1b7;">(Leave blank for Millburn students).</div> |
| <input type="checkbox" name="ps_remember" style="text-decoration: none !important;"></input> | ||
| </div> | ||
| <div class="col-md-3" style="margin-top: 1vh;"> | ||
| <div style="color: #aeb1b7;">(Your account is not stored in our servers!)</div> |
Contributor
There was a problem hiding this comment.
Your account information is not stored on our servers
Please check how this looks on mobile -- overlaps on top of the checkbox.
maclover7
reviewed
Nov 5, 2016
| <input type="checkbox" name="ps_remember" style="text-decoration: none !important;"></input> | ||
| </div> | ||
| <div class="col-md-3 col-xs-5" style="margin-top: 1vh;"> | ||
| <div style="color: #aeb1b7;">(Your account is not stored in our servers!)</div> |
Contributor
There was a problem hiding this comment.
This comment still needs to be resolved: #48 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e checkbox