Make readblock of EngineArray work for in memory arrays#29
Open
felixcremer wants to merge 1 commit intomainfrom
Open
Make readblock of EngineArray work for in memory arrays#29felixcremer wants to merge 1 commit intomainfrom
felixcremer wants to merge 1 commit intomainfrom
Conversation
We want the readblock and writeblock of an EngineArray backed by a in memory array to work.
asinghvi17
reviewed
Feb 18, 2025
| Base.parent(p::EngineArray) = p.parent | ||
| DiskArrays.readblock!(a::EngineArray,xout,r::OrdinalRange...) = DiskArrays.readblock!(a.parent,xout,r...) | ||
| DiskArrays.writeblock!(a::EngineArray,xout,r::OrdinalRange...) = DiskArrays.writeblock!(a.parent,xout,r...) | ||
| DiskArrays.readblock!(a::EngineArray,xout,r::OrdinalRange...) = a.parent isa AbstractDiskArray ? DiskArrays.readblock!(a.parent,xout,r...) : xout .= a.parent[r...] |
Contributor
There was a problem hiding this comment.
should this be isdisk(a.parent) instead?
Collaborator
Author
There was a problem hiding this comment.
That sounds about right.
There was a problem hiding this comment.
Well, parent(a) should be preferred, keep the getproperty in one place
Collaborator
|
@felixcremer is this outdated? or? |
Collaborator
Author
|
Let me have a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want the readblock and writeblock of an EngineArray backed by a in memory array to work.
This special cases the non-DiskArray case to use normal getindex instead of readblock!.