Package unifi: Implement Device.String().#10
Open
octo wants to merge 2 commits intomdlayher:masterfrom
Open
Conversation
octo
force-pushed
the
device-string
branch
3 times, most recently
from
255e23e to
6795ce6
Compare
Previously, tests failed with: $ go get github.com/golang/lint/golint package github.com/golang/lint/golint: code in directory /home/travis/gopath/src/github.com/golang/lint/golint expects import "golang.org/x/lint/golint"
Behaves like the Unifi UI, i.e. returns the device's name if set and the serial otherwise. If the serial has exactly 12 characters, it is formatted like a MAC address, again like the UI does.
Author
|
Hi, I've left the Travis fix in here for convenience. If you'd like this to be a separate PR, let me know. I've also ordered the commits for easy cherry-picking if that's helpful. Best regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behaves like the Unifi UI, i.e. returns the device's name if set and the serial otherwise. If the serial has exactly 12 characters, it is formatted like a MAC address, again like the UI does.