Open
Conversation
iswheeler
requested changes
Mar 27, 2026
Contributor
There was a problem hiding this comment.
Tested on Android emulator--looks good! Admittedly I'm not as familiar with the notification system so would probably be best if someone who has more experience with it could look this over too.
Just one small request--I noticed that when you edit your previous reminder settings, the dialog box shows you which buses you selected previously, but the slider always starts at 5 minutes. Could you make sure the dialog "remembers" the slider position (in addition to the checkboxes)?
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When setting notification requests for a stop, the app checks to make sure the notification list has the reminders to be added and omits the reminders to be deleted. Otherwise, a popup appears telling the user the notification request could not be sent.
Type of Change
feat)fix)Changes Made
stop_sheet.dartnow displays a different error messagemodifyReminders()inincoming_bus_reminder_service.dartnow checks backendTesting Done
Flutter:
flutter analyzeandflutter formatpassedflutter test)Backend:
Integration:
Checklist
[type](scope): short descriptionprint()/console.log()left in production code