Skip to content

Ensure notif reqests get sent#79

Open
Nnanyere wants to merge 3 commits intomaizebus-2.1from
ensure-notif-reqests-get-sent
Open

Ensure notif reqests get sent#79
Nnanyere wants to merge 3 commits intomaizebus-2.1from
ensure-notif-reqests-get-sent

Conversation

@Nnanyere
Copy link
Copy Markdown

@Nnanyere Nnanyere commented Mar 26, 2026

Description

When setting notification requests for a stop, the app checks to make sure the notification list has the reminders to be added and omits the reminders to be deleted. Otherwise, a popup appears telling the user the notification request could not be sent.

Type of Change

  • New feature (feat)
  • Bug fix (fix)
  • Refactor / code improvement
  • Dependency / build update
  • Documentation
  • Other (explain)

Changes Made

  • Flutter:
    • stop_sheet.dart now displays a different error message
    • modifyReminders() in incoming_bus_reminder_service.dart now checks backend

Testing Done

Flutter:

  • flutter analyze and flutter format passed
  • Unit / widget tests added or updated (flutter test)
  • Tested on:
    • iOS Simulator
    • Android Emulator
    • Physical device
  • Firebase notifications tested (foreground, background, killed app)
  • Offline mode / cache behavior checked

Backend:

  • TypeScript compilation & linting passed
  • Unit / integration tests passed
  • Tested API endpoints (Postman / curl)
  • Firebase Admin SDK behavior verified

Integration:

  • Flutter app successfully calls updated backend endpoints
  • End-to-end flow tested (e.g., bus arrival → notification)

Checklist

  • Commit messages follow Conventional Commits
  • PR title follows [type](scope): short description
  • No print() / console.log() left in production code
  • Code follows project style (Dart + ESLint/Prettier for TS)
  • Secrets / keys not committed

@Nnanyere Nnanyere linked an issue Mar 26, 2026 that may be closed by this pull request
@Nnanyere Nnanyere marked this pull request as draft March 26, 2026 05:04
@Nnanyere Nnanyere changed the base branch from main to maizebus-2.1 March 26, 2026 05:07
@Nnanyere Nnanyere marked this pull request as ready for review March 26, 2026 05:07
@Nnanyere Nnanyere requested review from i-kumar and kurz3m3 March 26, 2026 05:08
Copy link
Copy Markdown
Contributor

@iswheeler iswheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Android emulator--looks good! Admittedly I'm not as familiar with the notification system so would probably be best if someone who has more experience with it could look this over too.

Just one small request--I noticed that when you edit your previous reminder settings, the dialog box shows you which buses you selected previously, but the slider always starts at 5 minutes. Could you make sure the dialog "remembers" the slider position (in addition to the checkboxes)?

Image

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ensure notif reqests get sent

2 participants