Skip to content

made the dialog take in strings not widgets#65

Open
i-kumar wants to merge 4 commits intomaizebus-2.1from
47-modify-maizebusdialog-to-take-in-strings-not-widgets
Open

made the dialog take in strings not widgets#65
i-kumar wants to merge 4 commits intomaizebus-2.1from
47-modify-maizebusdialog-to-take-in-strings-not-widgets

Conversation

@i-kumar
Copy link
Member

@i-kumar i-kumar commented Mar 19, 2026

also replaced all the spots in the code where we called it with text

@i-kumar i-kumar linked an issue Mar 19, 2026 that may be closed by this pull request
@i-kumar i-kumar requested a review from iswheeler March 19, 2026 22:25
@iswheeler
Copy link
Contributor

iswheeler commented Mar 22, 2026

What's going on with the icon in mini_stop_sheet.dart 👀
Also please push to maizebus-2.1 branch instead of maizebus2

@iswheeler iswheeler closed this Mar 22, 2026
@i-kumar i-kumar reopened this Mar 22, 2026
@i-kumar i-kumar changed the base branch from main to maizebus-2.1 March 22, 2026 15:07
@i-kumar
Copy link
Member Author

i-kumar commented Mar 23, 2026

@iswheeler oops! sorry about that. I made a new commit to revert it. Can you approve this one?

(hint: NO, but you might have to open in VSCode and try to compile to see why)

also this time, try to "request changes" instead of closing the PR

Copy link
Contributor

@iswheeler iswheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you're missing a comma in mini_stop_sheet.dart

Image

@i-kumar i-kumar requested a review from iswheeler March 23, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modify MaizebusDialog to take in strings not widgets

2 participants