Skip to content

feat: Wayfinding Header/Section Implementation#2980

Merged
deanshi merged 1 commit intomainfrom
deanshi/wayfinding_header
Apr 2, 2026
Merged

feat: Wayfinding Header/Section Implementation#2980
deanshi merged 1 commit intomainfrom
deanshi/wayfinding_header

Conversation

@deanshi
Copy link
Copy Markdown
Contributor

@deanshi deanshi commented Mar 30, 2026

Asana task: [Wayfinding Widget and Wayfinding in Departures Header](https://app.asana.com/1/15492006741476/project/1185117109217413/task/1213100855318265?focus=true and https://app.asana.com/1/15492006741476/project/1185117109217413/task/1213739741735591?focus=true)

Screenshot 2026-04-01 at 10 17 05 AM Screenshot 2026-04-01 at 8 41 34 AM Screenshot 2026-04-01 at 8 42 37 AM

Description

  • image_path config for Departure Header can now be used to implement a Wayfinding image
  • we can use it to define images above departures, image only sections and full screen images using header_only
  • added a container div around sections that exposes a true-grey-70 section break for image section headers

@deanshi deanshi marked this pull request as ready for review March 31, 2026 13:42
@deanshi deanshi requested a review from a team as a code owner March 31, 2026 13:42
Comment on lines +4 to +7
&:not(:first-child) {
padding-top: 24px;
background-color: colors.$true-grey-70;
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implementation means that images and regular headers can't be mixed together, or we'll get this extra grey bar like below.

Image

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the logic so that if there's a title, it'll omit the spacing.

Screenshot 2026-04-01 at 10 18 58 AM

}

.departures-section {
background-color: #e6e4e1;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, and not particular to your PR, but this color is used all over the place for our LCD screen backgrounds. Should we add it to the constants in colors.scss? Maybe $warm-neutral-95

{(title || arrow) && <span>{title}</span>}
{arrow && <DirectionArrow arrow={arrow} />}
</header>
{imagePath && IMAGE_EXTENSIONS.includes(extensionForAsset(imagePath)) && (
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love the extensionForAsset consolidation! Since the evergreen content widget is doing the same thing of validating the extension against the same list of six, maybe that could be consolidated as well within utils.ts.
I just mean something like:

export const isImgExtension = (assetPath: string) => {
  const parts = assetPath.split(".");
  IMAGE_EXTENSIONS.includes(parts[parts.length - 1].toLowerCase());
};

And then the duplicated constant IMAGE_EXTENSIONS can also be consolidated there

@digitalcora
Copy link
Copy Markdown
Contributor

In the first screenshot, there is a tiny gap plus an extra border between the top of the widget and the top of the wayfinding graphic. Additionally, all the wayfinding graphics have a white gap on the left side, though maybe this is an artifact of how you exported the graphics themselves.

Screenshot 2026-03-31 at 3 21 31 PM

In the second screenshot, there is a tiny gap between the bottom of the wayfinding graphic and the top of the next section title.

Screenshot 2026-03-31 at 3 21 08 PM

In the third screenshot, there is a gap between the top of the widget and the top of the section title.

Screenshot 2026-03-31 at 3 20 33 PM

@deanshi
Copy link
Copy Markdown
Contributor Author

deanshi commented Mar 31, 2026

In the first screenshot, there is a tiny gap plus an extra border between the top of the widget and the top of the wayfinding graphic. Additionally, all the wayfinding graphics have a white gap on the left side, though maybe this is an artifact of how you exported the graphics themselves.
Screenshot 2026-03-31 at 3 21 31 PM

In the second screenshot, there is a tiny gap between the bottom of the wayfinding graphic and the top of the next section title.
Screenshot 2026-03-31 at 3 21 08 PM

In the third screenshot, there is a gap between the top of the widget and the top of the section title.
Screenshot 2026-03-31 at 3 20 33 PM

Let me get some proper assets from Betsy and put them in. These were just placeholders to see them in low-stakes action.

@deanshi
Copy link
Copy Markdown
Contributor Author

deanshi commented Apr 1, 2026

In the first screenshot, there is a tiny gap plus an extra border between the top of the widget and the top of the wayfinding graphic. Additionally, all the wayfinding graphics have a white gap on the left side, though maybe this is an artifact of how you exported the graphics themselves.
Screenshot 2026-03-31 at 3 21 31 PM

In the second screenshot, there is a tiny gap between the bottom of the wayfinding graphic and the top of the next section title.
Screenshot 2026-03-31 at 3 21 08 PM

In the third screenshot, there is a gap between the top of the widget and the top of the section title.
Screenshot 2026-03-31 at 3 20 33 PM

Screenshots have been updated and logic changed to add vertical-align: middle. Omitting that out was causing some extra space.

@deanshi deanshi requested a review from robbie-sundstrom April 1, 2026 14:37
Copy link
Copy Markdown
Contributor

@robbie-sundstrom robbie-sundstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks great, and the example header images look AMAZING. So excited for this

@digitalcora
Copy link
Copy Markdown
Contributor

One remaining misalignment with the designs that I can see: the "divider" included before image-only sections (those without text titles) should have a small darker border at the top.

Screenshot 2026-04-01 at 1 02 44 PM

@deanshi
Copy link
Copy Markdown
Contributor Author

deanshi commented Apr 1, 2026

One remaining misalignment with the designs that I can see: the "divider" included before image-only sections (those without text titles) should have a small darker border at the top.
Screenshot 2026-04-01 at 1 02 44 PM

Screenshot 2026-04-01 at 4 30 00 PM

Updated so that we now show the divider. I modified the CSS a little bit since the divider logic was based off of the header previously, but now we have a separate divider div handling that logic.

@robbie-sundstrom robbie-sundstrom self-requested a review April 2, 2026 13:31
Copy link
Copy Markdown
Contributor

@robbie-sundstrom robbie-sundstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good!

- image_path config for Departure Header can now be used to implement a
  Wayfinding image
- we can use it to define images above departures, image only sections
  and full screen images using `header_only`
- addeds a container div around sections that exposes a true-grey-70
  section break for image section headers
@deanshi deanshi force-pushed the deanshi/wayfinding_header branch from 49e4bfe to aabecf5 Compare April 2, 2026 17:18
@deanshi deanshi merged commit 469ddd5 into main Apr 2, 2026
12 checks passed
@deanshi deanshi deleted the deanshi/wayfinding_header branch April 2, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants