feat: Wayfinding Header/Section Implementation#2980
Conversation
| &:not(:first-child) { | ||
| padding-top: 24px; | ||
| background-color: colors.$true-grey-70; | ||
| } |
| } | ||
|
|
||
| .departures-section { | ||
| background-color: #e6e4e1; |
There was a problem hiding this comment.
Nit, and not particular to your PR, but this color is used all over the place for our LCD screen backgrounds. Should we add it to the constants in colors.scss? Maybe $warm-neutral-95
| {(title || arrow) && <span>{title}</span>} | ||
| {arrow && <DirectionArrow arrow={arrow} />} | ||
| </header> | ||
| {imagePath && IMAGE_EXTENSIONS.includes(extensionForAsset(imagePath)) && ( |
There was a problem hiding this comment.
love the extensionForAsset consolidation! Since the evergreen content widget is doing the same thing of validating the extension against the same list of six, maybe that could be consolidated as well within utils.ts.
I just mean something like:
export const isImgExtension = (assetPath: string) => {
const parts = assetPath.split(".");
IMAGE_EXTENSIONS.includes(parts[parts.length - 1].toLowerCase());
};
And then the duplicated constant IMAGE_EXTENSIONS can also be consolidated there
robbie-sundstrom
left a comment
There was a problem hiding this comment.
code looks great, and the example header images look AMAZING. So excited for this
robbie-sundstrom
left a comment
There was a problem hiding this comment.
changes look good!
- image_path config for Departure Header can now be used to implement a Wayfinding image - we can use it to define images above departures, image only sections and full screen images using `header_only` - addeds a container div around sections that exposes a true-grey-70 section break for image section headers
49e4bfe to
aabecf5
Compare














Asana task: [Wayfinding Widget and Wayfinding in Departures Header](https://app.asana.com/1/15492006741476/project/1185117109217413/task/1213100855318265?focus=true and https://app.asana.com/1/15492006741476/project/1185117109217413/task/1213739741735591?focus=true)
Description
header_only