This repository was archived by the owner on Nov 22, 2021. It is now read-only.
Fix "on-" callback issues when using use-strings="true"#875
Open
cgatesman wants to merge 2 commits intombenford:masterfrom
Open
Fix "on-" callback issues when using use-strings="true"#875cgatesman wants to merge 2 commits intombenford:masterfrom
cgatesman wants to merge 2 commits intombenford:masterfrom
Conversation
Fixes mbenford#874 Several issues were found while debugging and fixing mbenford#874: - Pass just tag name string to callback functions when using `use-strings="true"` - Call callback functions in a `$timeout` to ensure model has been appropriately updated with just tag strings before the callback is called. The model is updated in a watcher so it is asynchronously updated - Use `$watchCollection` for tags watcher - Do not clobber tags container when adding/removing items
cgatesman
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #874
Several issues were found while debugging and fixing #874:
use-strings="true"$timeoutto ensure model has been appropriately updated with just tag strings before the callback is called. The model is updated by a series of events and a watcher so it is asynchronously updated on an add or remove.$watchCollectionfor tags watchertagscontainer when adding/removing items