Fixes bug on Android/Chrome because Android does not sends the correct keyCode#692
Fixes bug on Android/Chrome because Android does not sends the correct keyCode#692gnarvaja wants to merge 5 commits intombenford:masterfrom
Conversation
keyCode. Manually detects comma from the input text.
|
@gnarvaja The travis report shows you only need to change '==' to '===' on line 416 to pass the tests. I have tested this code in Chrome Desktop and Android Chrome and it does seem to fix the problem with comma. |
|
Was the problem that it would not detect when a user on Android or Chrome pressed the comma key? If that is the case, I am experiencing something similar. |
|
This getting merged anytime soon? |
|
Just wanted to note that this is not working for me. Not sure how it works for anyone. First, it only handles the comma case but the component supports space and enter as well. Second, and more importantly, because this runs during the keydown event, the input has not been updated with the key that was pressed. I.e. if the value of the input field is |
Manually detects comma from the input text.