Skip to content

resolve various code quality issues#28

Merged
mbdevpl merged 11 commits intomainfrom
feature/code-quality
Mar 13, 2025
Merged

resolve various code quality issues#28
mbdevpl merged 11 commits intomainfrom
feature/code-quality

Conversation

@mbdevpl
Copy link
Owner

@mbdevpl mbdevpl commented Mar 13, 2025

No description provided.

@mbdevpl mbdevpl self-assigned this Mar 13, 2025
@jenkins-mbdev
Copy link

jenkins-mbdev bot commented Mar 13, 2025

Tools report for GitHub-mbdevpl/ingit/PR-28 [build #7]:

  • Pylint: ran 🆗

  • Mypy: ran 🆗

  • Flake518: ran 🆗

  • Pydocstyle: ran 🆗

  • Coverage: 94% 🆗 (click for details)
    Name                             Stmts   Miss Branch BrPart  Cover   Missing
    ----------------------------------------------------------------------------
    ingit/__init__.py                    2      0      0      0   100%
    ingit/__main__.py                    9      0      2      0   100%
    ingit/_version.py                    2      0      0      0   100%
    ingit/action_progress.py            77      2     28      0    98%   61-62
    ingit/fetch_flags.py                27      3     10      3    84%   39, 48, 51
    ingit/json_config.py                73      0      8      0   100%
    ingit/main.py                       99      6     34      1    95%   234-235, 256-259
    ingit/project.py                   383     57    154     24    82%   32-43, 168->170, 185-195, 203-204, 208, 216, 226, 268, 299->306, 300->299, 326, 335-337, 354, 372, 393-394, 403, 414->416, 420-421, 432-433, 440-441, 458-459, 468->470, 488, 495, 548-550, 556-558, 562-563, 567, 572-575, 577
    ingit/push_flags.py                 15      0      4      1    95%   35->37
    ingit/repo_data.py                  93      0     20      0   100%
    ingit/runtime.py                   218     25     84      8    87%   62-64, 103, 153-154, 158-166, 175, 180->182, 190, 203-204, 215->exit, 276, 280->282, 288-290, 316-317
    ingit/runtime_interface.py          60      2     22      2    95%   66, 77
    setup.py                            11      0      2      0   100%
    test/__init__.py                     5      0      0      0   100%
    test/test_action_progress.py       135      0     22      0   100%
    test/test_git_commands.py          142      0     22      1    99%   47->49
    test/test_ingit_commands.py         95      0      8      0   100%
    test/test_json_config.py            78      0      0      0   100%
    test/test_main.py                   37      0      2      0   100%
    test/test_packaging.py               3      0      0      0   100%
    test/test_project.py               233      0     12      0   100%
    test/test_repo_data.py              65      0      0      0   100%
    test/test_runtime.py                67      0      8      0   100%
    test/test_runtime_interface.py      25      0      6      0   100%
    ----------------------------------------------------------------------------
    TOTAL                             1954     95    448     40    94%
    

@codecov
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 88.05031% with 19 lines in your changes missing coverage. Please review.

Project coverage is 94.1%. Comparing base (e637745) to head (4daafe0).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
ingit/project.py 71.9% 9 Missing and 7 partials ⚠️
ingit/runtime.py 92.8% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main     #28     +/-   ##
=======================================
+ Coverage   93.7%   94.1%   +0.4%     
=======================================
  Files         24      24             
  Lines       1887    1954     +67     
  Branches     223     224      +1     
=======================================
+ Hits        1769    1840     +71     
+ Misses        82      78      -4     
  Partials      36      36             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mbdevpl mbdevpl merged commit e3e316b into main Mar 13, 2025
17 of 18 checks passed
@mbdevpl mbdevpl deleted the feature/code-quality branch March 13, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant