Skip to content

🐛 [#738] use local objecttypes endpoint in permission form#739

Merged
stevenbal merged 1 commit intomasterfrom
issue/738-Permission-form-use-local-objecttypes
Mar 17, 2026
Merged

🐛 [#738] use local objecttypes endpoint in permission form#739
stevenbal merged 1 commit intomasterfrom
issue/738-Permission-form-use-local-objecttypes

Conversation

@OlhaZahoruiko
Copy link
Contributor

@OlhaZahoruiko OlhaZahoruiko commented Mar 2, 2026

Fixes #738

Changes

[Describe the changes here]

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2026

🐰 Bencher Report

Branchissue/738-Permission-form-use-local-objecttypes
Testbedubuntu-24.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
milliseconds (ms)
(Result Δ%)
Upper Boundary
milliseconds (ms)
(Limit %)
performance_test/tests/test_objects_list.py::test_objects_api_list_filter_by_object_type📈 view plot
🚷 view threshold
127.30 ms
(+4.14%)Baseline: 122.24 ms
128.35 ms
(99.18%)
performance_test/tests/test_objects_list.py::test_objects_api_list_filter_one_result📈 view plot
🚷 view threshold
20.51 ms
(+2.43%)Baseline: 20.02 ms
21.03 ms
(97.55%)
performance_test/tests/test_objects_list.py::test_objects_api_list_large_page_size_page_1📈 view plot
🚷 view threshold
328.71 ms
(+3.39%)Baseline: 317.94 ms
333.84 ms
(98.46%)
performance_test/tests/test_objects_list.py::test_objects_api_list_large_page_size_page_5📈 view plot
🚷 view threshold
330.41 ms
(+3.39%)Baseline: 319.57 ms
335.55 ms
(98.47%)
performance_test/tests/test_objects_list.py::test_objects_api_list_small_page_size_page_20📈 view plot
🚷 view threshold
130.45 ms
(+3.96%)Baseline: 125.49 ms
131.76 ms
(99.01%)
🐰 View full continuous benchmarking report in Bencher

@OlhaZahoruiko OlhaZahoruiko force-pushed the issue/738-Permission-form-use-local-objecttypes branch from bf659e5 to fae07dc Compare March 2, 2026 14:49
@OlhaZahoruiko OlhaZahoruiko marked this pull request as ready for review March 2, 2026 14:50
@OlhaZahoruiko OlhaZahoruiko requested a review from stevenbal March 2, 2026 14:59
@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.87%. Comparing base (8d03167) to head (3e57e21).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #739      +/-   ##
==========================================
+ Coverage   85.58%   85.87%   +0.28%     
==========================================
  Files         144      144              
  Lines        3003     3022      +19     
  Branches      236      239       +3     
==========================================
+ Hits         2570     2595      +25     
+ Misses        381      376       -5     
+ Partials       52       51       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@stevenbal stevenbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add a test for this form with playwright? Floris added playwright in Open Zaak some time ago as well open-zaak/open-zaak#2289

@OlhaZahoruiko OlhaZahoruiko force-pushed the issue/738-Permission-form-use-local-objecttypes branch 3 times, most recently from 472b5ae to 0e11278 Compare March 3, 2026 17:00
@OlhaZahoruiko OlhaZahoruiko force-pushed the issue/738-Permission-form-use-local-objecttypes branch from 55882df to 4c644f3 Compare March 5, 2026 13:17
Copy link
Collaborator

@stevenbal stevenbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall 👍

Some minor things remaining

@OlhaZahoruiko OlhaZahoruiko force-pushed the issue/738-Permission-form-use-local-objecttypes branch 2 times, most recently from 3028dc3 to 014aa8f Compare March 9, 2026 14:41
@OlhaZahoruiko OlhaZahoruiko requested a review from stevenbal March 9, 2026 14:53
Copy link
Collaborator

@stevenbal stevenbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing remaining is the manual build in CI, rest looks good

@OlhaZahoruiko OlhaZahoruiko force-pushed the issue/738-Permission-form-use-local-objecttypes branch 4 times, most recently from ea64c65 to 30453b3 Compare March 17, 2026 11:58
@OlhaZahoruiko OlhaZahoruiko force-pushed the issue/738-Permission-form-use-local-objecttypes branch from b948235 to 3e57e21 Compare March 17, 2026 13:04
@OlhaZahoruiko OlhaZahoruiko requested a review from stevenbal March 17, 2026 13:21
@stevenbal stevenbal merged commit cc66ee5 into master Mar 17, 2026
28 checks passed
@stevenbal stevenbal deleted the issue/738-Permission-form-use-local-objecttypes branch March 17, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Permission admin field based authorization form should use local objecttypes

4 participants