🐛 [#738] use local objecttypes endpoint in permission form#739
Merged
🐛 [#738] use local objecttypes endpoint in permission form#739
Conversation
Contributor
bf659e5 to
fae07dc
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #739 +/- ##
==========================================
+ Coverage 85.58% 85.87% +0.28%
==========================================
Files 144 144
Lines 3003 3022 +19
Branches 236 239 +3
==========================================
+ Hits 2570 2595 +25
+ Misses 381 376 -5
+ Partials 52 51 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stevenbal
requested changes
Mar 2, 2026
Collaborator
stevenbal
left a comment
There was a problem hiding this comment.
Could you also add a test for this form with playwright? Floris added playwright in Open Zaak some time ago as well open-zaak/open-zaak#2289
472b5ae to
0e11278
Compare
55882df to
4c644f3
Compare
stevenbal
requested changes
Mar 5, 2026
Collaborator
stevenbal
left a comment
There was a problem hiding this comment.
Looks good overall 👍
Some minor things remaining
3028dc3 to
014aa8f
Compare
stevenbal
requested changes
Mar 12, 2026
Collaborator
stevenbal
left a comment
There was a problem hiding this comment.
Only thing remaining is the manual build in CI, rest looks good
ea64c65 to
30453b3
Compare
stevenbal
reviewed
Mar 17, 2026
b948235 to
3e57e21
Compare
stevenbal
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #738
Changes
[Describe the changes here]