Open
Conversation
Contributor
|
Newest code from mattermost has been published to preview environment for Git SHA f0dbe85 |
Contributor
|
Newest code from mattermost has been published to preview environment for Git SHA 6083606 |
Contributor
|
Newest code from mattermost has been published to preview environment for Git SHA bdaa2f9 |
Contributor
|
Newest code from mattermost has been published to preview environment for Git SHA ad2ebfa |
Contributor
|
Newest code from mattermost has been published to preview environment for Git SHA ca0a175 |
Contributor
|
Newest code from mattermost has been published to preview environment for Git SHA 418c643 |
* Added note on CJKSearch feature flag * Fix version typo: this will be released in v11.5 * Add link to FAQ for using ES/OS after 2.5M posts * Update source/deployment-guide/software-hardware-requirements.rst Co-authored-by: Ibrahim Serdar Acikgoz <serdaracikgoz86@gmail.com> --------- Co-authored-by: Ibrahim Serdar Acikgoz <serdaracikgoz86@gmail.com>
Contributor
|
Newest code from mattermost has been published to preview environment for Git SHA 199da92 |
Contributor
|
Newest code from mattermost has been published to preview environment for Git SHA a46170f |
Contributor
|
Newest code from mattermost has been published to preview environment for Git SHA 13c0847 |
* add docs for autotranslations * model info * Address PR review feedback for autotranslation docs - Rename "autotranslation" to "Auto-translation" to match UI - Fix "toggle" wording to describe selecting translation icon - Add Agents plugin link at first mention - Restructure with "Set up a translation provider" parent heading - Move "Enable" section after provider configuration - Rename "Manage per channel" to "Enable Auto-translation in a channel" - Add note that only new messages are translated - Add intro paragraph to "Tune worker performance" - Link directly to LibreTranslate install docs - Rename "Target languages" to "Languages allowed" in config reference - Mark Translation workers/timeout as config-only settings - Reorder config settings to match System Console UI - Clarify code-only messages as expected behavior in end-user guide Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Update LibreTranslate link to official installation guide Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Add parent Set up Auto-translation heading, nest provider/enable sections Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Reorder config settings to match System Console UI order Order: Enable, Provider, LibreTranslate URL/Key, Agents LLM service ID, Languages allowed, Translation timeout, Restrict DMs/GMs, then Translation workers (mmctl/config.json only) last. Also restores Translation timeout as a UI-visible setting. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Add intro sentence under Configure a translation provider heading Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Fix Agents LLM service ID table rendering Remove cross-line :doc: reference that broke the grid table column parsing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Update server-configuration.rst * Update collaborate-within-channels.rst * Update autotranslate-messages.rst * Update site-configuration-settings.rst --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Eric Sethna <14333569+esethna@users.noreply.github.com>
…0) (#8776) Document the new non_channel_member_access audit log field introduced in Mattermost v11.5.0. When a user accesses posts or content in a channel they are not a member of, this field in the meta object is set to true, allowing admins to identify and review such access in audit logs. Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com> Co-authored-by: Combs7th <Combs7th@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Newest code from mattermost has been published to preview environment for Git SHA 2af3803 |
Contributor
|
Newest code from mattermost has been published to preview environment for Git SHA 07e65fb |
…v11.5 (#8778) - Document citation links in AI channel summaries: clicking a citation opens a popover preview of the referenced message inline - Document the new Channel Header Icon pluggable location in the integrations guide, available from Mattermost v11.5 Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com> Co-authored-by: Combs7th <Combs7th@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
…8785) From Mattermost v11.5, archived private channels display a distinct Archive Lock icon to visually differentiate them from archived public channels. Update channel-types.rst and archive-unarchive-channels.rst to reflect this UI change. Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com> Co-authored-by: Combs7th <Combs7th@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Newest code from mattermost has been published to preview environment for Git SHA 65d0336 |
Contributor
|
Newest code from mattermost has been published to preview environment for Git SHA cadb3cb |
Documents the new mmctl license get command available from Mattermost server v11.5 onward, following the existing style and formatting conventions of the mmctl command reference page. Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com> Co-authored-by: Combs7th <Combs7th@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Newest code from mattermost has been published to preview environment for Git SHA 0b603f4 |
amyblais
added
Do Not Merge
📝 WalkthroughWalkthroughUpdates Mattermost docs for v11.5: adds audit log schema fields and recap events, introduces Auto-translation docs and settings, new mmctl license get command, multiple upgrade/migration notes, version bumps and release entries, deployment URL updates, UI/UX notes (archive icon, AI rewrites, mobile features), and other documentation additions/edits. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can customize the tone of the review comments and chat replies.Configure the |
Member
Author
|
@coderabbitai help |
ChatThere are 3 ways to chat with CodeRabbit:
CodeRabbit commands
Other keywords and placeholders
CodeRabbit configuration file (
|
Contributor
|
Newest code from mattermost has been published to preview environment for Git SHA 068bec3 |
Member
Author
|
@coderabbitai review |
Contributor
|
Newest code from mattermost has been published to preview environment for Git SHA 1a45f35 |
✅ Actions performedReview triggered.
|
Member
Author
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 11
🧹 Nitpick comments (1)
source/administration-guide/comply/embedded-json-audit-log-schema.rst (1)
915-935: AI Recap Events section is well-structured.The new section properly documents all recap-related audit events with clear descriptions and helpful guidance about the
channel_idparameter for compliance monitoring.Optional enhancement: Consider mentioning
channel_idin individual event descriptions.The introductory paragraph (line 918) notes that recap events include
channel_idin parameters, but the individual event descriptions (lines 923-934) don't mention this. For completeness, you could note the parameter in the descriptions, e.g., "Creating channel recaps (includes channel_id)".However, since the introductory paragraph already clarifies this for the entire section, the current approach is acceptable.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@source/administration-guide/comply/embedded-json-audit-log-schema.rst` around lines 915 - 935, The section lists AI recap events (createRecap, deleteRecap, getRecap, getRecaps, markRecapAsRead, regenerateRecap) but only the intro mentions the channel_id parameter; update each event description to append a short note like "(includes channel_id)" so readers see parameter relevance on each line—modify the descriptions for createRecap, deleteRecap, getRecap, getRecaps, markRecapAsRead, and regenerateRecap accordingly to include the channel_id mention.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@source/administration-guide/configure/enabling-chinese-japanese-korean-search.rst`:
- Line 18: The :doc: role invocation has incorrect backtick usage in the string
"See :doc:``database requirements documentation
</deployment-guide/software-hardware-requirements>`" — replace the double
opening backticks after :doc: with a single backtick and ensure a matching
closing backtick so the role reads like :doc:`database requirements
documentation </deployment-guide/software-hardware-requirements>`; update the
text in the file containing the :doc: role
(enabling-chinese-japanese-korean-search.rst) accordingly.
- Line 13: The sentence "The general recommendation of `using either
Elasticsearch or Opensearch once the server reaches 2.5 million posts
https://docs.mattermost.com/administration-guide/scale/enterprise-search.html#do-i-need-to-use-elasticsearch-or-aws-opensearch`
still applies." has a malformed RST link; replace the inline text+URL with
proper RST inline link syntax by wrapping the link text and URL as: `using
either Elasticsearch or Opensearch once the server reaches 2.5 million posts
<https://docs.mattermost.com/administration-guide/scale/enterprise-search.html#do-i-need-to-use-elasticsearch-or-aws-opensearch>`_
so the URL becomes a clickable hyperlink in the rendered documentation.
In `@source/administration-guide/configure/site-configuration-settings.rst`:
- Line 11: The "Auto-translation <#autotranslation>" entry is currently listed
as a top-level Site Configuration item but the actual section is nested under
"Site Configuration > Localization"; update the section list so that the
Auto-translation link appears under the Localization subsection (i.e., move or
re-indent the `Auto-translation <#autotranslation>` entry to be grouped with the
Localization entries) to match the System Console navigation and avoid
misleading admins.
- Line 605: Update the section intro that currently reads "Access the following
configuration settings in the System Console by going to **Site Configuration >
Localization**" to clarify that only some settings are available in the System
Console and that config-only settings must be changed outside the UI;
specifically mention the "Translation workers" setting as an example of a
config-only setting not present in the System Console and instruct readers to
configure such settings via config files or environment variables. Apply the
same qualification to the parallel text around the later occurrence (the block
covering lines 762–767) so both places clearly distinguish System
Console-managed settings from config-only settings like "Translation workers."
In `@source/administration-guide/manage/admin/autotranslation.rst`:
- Line 42: Update the RST cross-reference targets that use spaces instead of
hyphens: replace occurrences like
``<administration-guide/configure/site-configuration-settings:libretranslate
url>`` with ``...:libretranslate-url>``, ``libretranslate api key`` →
``libretranslate-api-key``, ``agents llm service id`` →
``agents-llm-service-id``, ``enable autotranslation`` →
``enable-auto-translation``, ``translation provider`` →
``translation-provider``, ``languages allowed`` → ``languages-allowed``,
``restrict autotranslation in direct and group messages`` →
``restrict-autotranslation-in-direct-and-group-messages``, ``translation
workers`` → ``translation-workers``, and ``translation timeout`` →
``translation-timeout`` so the implicit anchors generated from the subsection
headings match the :ref: targets (leave the explicit ``_autotranslation:``
anchor reference as-is).
In `@source/administration-guide/upgrade/important-upgrade-notes.rst`:
- Around line 18-73: Remove the stray literal "sql" line inside each code-block
example (keep the ".. code-block:: sql" directive only); specifically, edit the
code blocks that contain the SQL snippets starting with "ALTER TABLE
translations ADD COLUMN IF NOT EXISTS state...", "CREATE INDEX IF NOT EXISTS
idx_translations_state...", "ALTER TABLE channelmembers ADD COLUMN IF NOT EXISTS
autotranslationdisabled...", "UPDATE translations SET objectType = 'post'...",
"ALTER TABLE translations ADD COLUMN IF NOT EXISTS channelid...", "CREATE INDEX
CONCURRENTLY IF NOT EXISTS idx_translations_channel_updateat..." and "DROP INDEX
CONCURRENTLY IF EXISTS idx_translations_updateat;" and remove the extra line
that contains just "sql" so the examples contain only the intended SQL commands.
- Around line 37-46: The wording about changing the primary key on the
translations table is misleading: dropping and re-adding the primary key (the
ALTER TABLE ... DROP CONSTRAINT translations_pkey; and ALTER TABLE ... ADD
PRIMARY KEY (objectId, objectType, dstLang); operations on the translations
table) requires an ACCESS EXCLUSIVE lock in PostgreSQL and can block all reads
and writes; update the paragraph that currently claims “no database downtime is
expected” to explicitly state that this step requires a maintenance
window/off-hours work (or appropriate downtime), warn that it will block
concurrent access while the constraint is replaced, and advise scheduling the
ALTER TABLE operations during a planned maintenance window.
- Around line 15-26: Fix the SQL block and upgrade notes: remove the stray "sql"
token after the ``.. code-block:: sql`` directive; change the ALTER TABLE in the
v11.5 notes to add the new column with a DEFAULT (e.g. ALTER TABLE translations
ADD COLUMN IF NOT EXISTS state varchar(20) NOT NULL DEFAULT 'processing') and
ensure existing rows are updated before relying on NOT NULL; create non-blocking
indexes first by using CREATE INDEX CONCURRENTLY (or CREATE UNIQUE INDEX
CONCURRENTLY IF NOT EXISTS translations_pkey_idx ON translations(objectId,
objectType, dstLang)) and then attach it as the primary key with ALTER TABLE
translations ADD PRIMARY KEY USING INDEX translations_pkey_idx instead of DROP
CONSTRAINT/ADD PRIMARY KEY to avoid ACCESS EXCLUSIVE locks; and keep the
existing CREATE INDEX IF NOT EXISTS idx_translations_state ON
translations(state) clause but consider using CONCURRENTLY if the table is
large.
In `@source/deployment-guide/software-hardware-requirements.rst`:
- Line 112: Update the inconsistent MySQL ngram documentation link: locate the
older 5.7 ngram URL string
("https://dev.mysql.com/doc/refman/5.7/en/fulltext-search-ngram.html")
referenced later in the file and replace it with the 8.4 ngram URL
("https://dev.mysql.com/doc/refman/8.4/en/fulltext-search-ngram.html") so both
CJK/full-text parser mentions match the same MySQL version and configuration
guidance.
In `@source/end-user-guide/collaborate/channel-types.rst`:
- Line 68: Rewrite the sentence to explicitly state which channel types use each
icon: say that archived private channels display the distinct "Archive Lock"
icon (|archive-lock|) while archived public, direct message, and group message
channels use the "File Box" icon (|file-box|); update the text around the
existing phrases **File Box** |file-box| and **Archive Lock** to make the
distinction clear and place the private-channel exception up front.
In `@source/end-user-guide/workflow-automation/work-with-tasks.rst`:
- Around line 104-108: Update the mobile features wording to tighten
availability and parity: change the section opener that currently implies all
task features are available since v2.32.0 to state that certain task
capabilities (specifically "Rename tasks" and "Add or edit task descriptions")
were introduced in mobile v2.38.0 and "Delete a task" in v2.37.0, and revise the
closing sentence that claims full parity so it instead says these mobile
releases deliver many core task-management features while noting that advanced
capabilities like conditional tasks, task actions, and the task inbox remain
desktop/web-only.
---
Nitpick comments:
In `@source/administration-guide/comply/embedded-json-audit-log-schema.rst`:
- Around line 915-935: The section lists AI recap events (createRecap,
deleteRecap, getRecap, getRecaps, markRecapAsRead, regenerateRecap) but only the
intro mentions the channel_id parameter; update each event description to append
a short note like "(includes channel_id)" so readers see parameter relevance on
each line—modify the descriptions for createRecap, deleteRecap, getRecap,
getRecaps, markRecapAsRead, and regenerateRecap accordingly to include the
channel_id mention.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: e5edac36-26d8-404e-89f7-c8eb16561af3
⛔ Files ignored due to path filters (1)
source/_generated/agents/docs/user_guide.mdis excluded by!**/_generated/**
📒 Files selected for processing (25)
source/administration-guide/comply/embedded-json-audit-log-schema.rstsource/administration-guide/configure/enabling-chinese-japanese-korean-search.rstsource/administration-guide/configure/site-configuration-settings.rstsource/administration-guide/manage/admin/autotranslation.rstsource/administration-guide/manage/admin/server-configuration.rstsource/administration-guide/manage/mmctl-command-line-tool.rstsource/administration-guide/upgrade/important-upgrade-notes.rstsource/administration-guide/upgrade/open-source-components.rstsource/conf.pysource/deployment-guide/server/linux/deploy-rhel.rstsource/deployment-guide/server/linux/deploy-tar.rstsource/deployment-guide/software-hardware-requirements.rstsource/end-user-guide/collaborate/archive-unarchive-channels.rstsource/end-user-guide/collaborate/autotranslate-messages.rstsource/end-user-guide/collaborate/channel-types.rstsource/end-user-guide/collaborate/collaborate-within-channels.rstsource/end-user-guide/collaborate/send-messages.rstsource/end-user-guide/workflow-automation/work-with-tasks.rstsource/integrations-guide/plugins.rstsource/product-overview/mattermost-desktop-releases.mdsource/product-overview/mattermost-server-releases.mdsource/product-overview/mattermost-v11-changelog.mdsource/product-overview/plans.mdsource/product-overview/release-policy.mdsource/product-overview/ui-ada-changelog.rst
💤 Files with no reviewable changes (1)
- source/product-overview/plans.md
source/administration-guide/configure/enabling-chinese-japanese-korean-search.rst
Show resolved
Hide resolved
source/administration-guide/configure/enabling-chinese-japanese-korean-search.rst
Show resolved
Hide resolved
amyblais
added
3: Reviews Complete
Contributor
|
Newest code from mattermost has been published to preview environment for Git SHA b4c34b8 |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
source/product-overview/mattermost-v11-changelog.md (2)
76-76: Use lowercase "post" for consistency.The term "Post" should be lowercase when used as a common noun rather than part of a proper name.
📝 Proposed fix
- - Added [CJK Post search support for PostgreSQL](https://docs.mattermost.com/administration-guide/configure/enabling-chinese-japanese-korean-search.html), which sits behind the new feature flag ``MM_FEATUREFLAGS_CJKSEARCH`` [MM-67671](https://mattermost.atlassian.net/browse/MM-67671). + - Added [CJK post search support for PostgreSQL](https://docs.mattermost.com/administration-guide/configure/enabling-chinese-japanese-korean-search.html), which sits behind the new feature flag ``MM_FEATUREFLAGS_CJKSEARCH`` [MM-67671](https://mattermost.atlassian.net/browse/MM-67671).🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@source/product-overview/mattermost-v11-changelog.md` at line 76, Update the changelog line containing "CJK Post search support for PostgreSQL" to use lowercase "post" (i.e., change "CJK Post search support for PostgreSQL" to "CJK post search support for PostgreSQL"); the rest of the text including the feature flag MM_FEATUREFLAGS_CJKSEARCH and the link should remain unchanged.
19-19: Consider standardizing auto-translation terminology.The documentation uses multiple variants: "autotranslations" (line 19), "Autotranslation" (line 39), and "auto-translations" (line 59). While some variation may be intentional based on context (worker processes vs. configuration settings vs. user-facing features), consider standardizing the hyphenation and capitalization where appropriate for improved consistency and clarity.
Also applies to: 39-39, 59-59
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@source/product-overview/mattermost-v11-changelog.md` at line 19, The doc uses three inconsistent variants ("autotranslations", "Autotranslation", "auto-translations"); standardize to a single form—use lowercase "auto-translation" (plural "auto-translations") for general text and "auto-translation workers" when referring to worker processes, capitalizing only for headings if needed; find and replace occurrences of "autotranslations", "Autotranslation", and "auto-translations" with the chosen forms and adjust surrounding wording for grammar and plurality.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@source/product-overview/mattermost-v11-changelog.md`:
- Line 20: Update the release note text so the file-format acronym is
capitalized: replace the phrase "main json import file" with "main JSON import
file" in the line containing "Fixed an issue with the import process looking for
the main json import file in subfolders of the export zip file." within the
mattermost-v11-changelog.md content.
---
Nitpick comments:
In `@source/product-overview/mattermost-v11-changelog.md`:
- Line 76: Update the changelog line containing "CJK Post search support for
PostgreSQL" to use lowercase "post" (i.e., change "CJK Post search support for
PostgreSQL" to "CJK post search support for PostgreSQL"); the rest of the text
including the feature flag MM_FEATUREFLAGS_CJKSEARCH and the link should remain
unchanged.
- Line 19: The doc uses three inconsistent variants ("autotranslations",
"Autotranslation", "auto-translations"); standardize to a single form—use
lowercase "auto-translation" (plural "auto-translations") for general text and
"auto-translation workers" when referring to worker processes, capitalizing only
for headings if needed; find and replace occurrences of "autotranslations",
"Autotranslation", and "auto-translations" with the chosen forms and adjust
surrounding wording for grammar and plurality.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: df944cb0-442c-453b-a590-99d4e9ce2f4d
📒 Files selected for processing (1)
source/product-overview/mattermost-v11-changelog.md
amyblais
added
Do Not Merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Release Notes v11.5
New Features
Documentation