Yncyrydybyl/fix waitforcomplete transformation#1252
Open
yncyrydybyl wants to merge 6 commits intomatrix-org:mainfrom
Open
Yncyrydybyl/fix waitforcomplete transformation#1252yncyrydybyl wants to merge 6 commits intomatrix-org:mainfrom
yncyrydybyl wants to merge 6 commits intomatrix-org:mainfrom
Conversation
Two fixes:
1. GenericHook.ts: Don't mark webhook as failed when the transformation
function throws. The message still gets delivered to the room with
fallback text, so the webhook was successfully processed. Previously,
waitForComplete callers received {"ok":false} even though the message
was posted.
2. Bridge.ts: When waitForComplete is enabled and onGenericHook throws
(e.g. Matrix send failure), queue a proper error response with the
actual error message instead of falling through to a generic
{"ok":false,"error":"Failed to process webhook"}.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Verifies that onGenericHook returns successful:true even when the transformation function throws, since the message is still delivered with fallback text. Also tests that webhookResponse flows through from a successful transformation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Tests the full matrix of onGenericHook return values: successful transformations with/without webhookResponse, failed transformations (fallback text delivery, no webhookResponse leak), empty results with webhookResponse, simple webhooks without transformations, and custom msgtype handling. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #1251.
This is mainly created by claude and should be carefully reviewed before merging.