Add support for 'relates_to' in GenericHook#1106
Open
gamedolphin wants to merge 6 commits intomatrix-org:mainfrom
Open
Add support for 'relates_to' in GenericHook#1106gamedolphin wants to merge 6 commits intomatrix-org:mainfrom
gamedolphin wants to merge 6 commits intomatrix-org:mainfrom
Conversation
Signed-off-by: Sandeep Nambiar <contact@sandeepnambiar.com>
Signed-off-by: Sandeep Nambiar <contact@sandeepnambiar.com>
Signed-off-by: Sandeep Nambiar <contact@sandeepnambiar.com>
Signed-off-by: Sandeep Nambiar <contact@sandeepnambiar.com>
Signed-off-by: Sandeep Nambiar <contact@sandeepnambiar.com>
Fix this type check Signed-off-by: Sandeep Nambiar <contact@sandeepnambiar.com>
Half-Shot
requested changes
Nov 27, 2025
Contributor
Half-Shot
left a comment
Half-Shot
left a comment
There was a problem hiding this comment.
Looks fine, but can we also get a test. Either a unit or integration test will do :)
| } | ||
|
|
||
| if (typeof safeData?.relates_to === "object") { | ||
| msg.relates_to = safeData.relates_to ?? undefined; |
Contributor
There was a problem hiding this comment.
I think this needs stronger validation, at least checking whether the object looks like a relates_to object?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor enhancement to the
GenericHookConnectionclass, adding support for including a new property in the message content if present.relates_toproperty in the outgoing message content, allowing messages to include relation information when available.