Fix typo in getDelimiter space/hyphen index comparison#758
Open
wladerer wants to merge 1 commit intomaterialsproject:mainfrom
Open
Fix typo in getDelimiter space/hyphen index comparison#758wladerer wants to merge 1 commit intomaterialsproject:mainfrom
wladerer wants to merge 1 commit intomaterialsproject:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When querying ternary phase diagrams, 'Li-Zn-O' and 'Li - Zn - O' produce very different results. I suppose the actual fix is for the user (me) to use the formatting convention suggested by the website, but it seems like a nice thing to have.
space.index > space.index on line 133 always evaluates to false
Major changes:
(!hyphen || (hyphen.index && space.index > space.index))->(!hyphen || (hyphen.index && space.index > hyphen.index))