Enable launchpad and fireworker config be passed via json string#499
Open
JBlaschke wants to merge 3 commits intomaterialsproject:mainfrom
Open
Enable launchpad and fireworker config be passed via json string#499JBlaschke wants to merge 3 commits intomaterialsproject:mainfrom
JBlaschke wants to merge 3 commits intomaterialsproject:mainfrom
Conversation
Member
|
Thanks! But I see a typo: launchpad_generator = lambda x: LaunchPad.form_file(x) Can you fix and also run through the confirm the previous options are working correctly after the changes? |
Contributor
Author
|
@computron thanks for catching that! Fixed. |
Member
|
@JBlaschke Could you add a test for this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a relatively simple addition to the
rlaunchCLI tool: When--jsonis provided, then the inputs to-land-ware JSON-formatted strings. This is mainly to allow forLaunchPadandFWorkerto be specified in a python script, without having to generate these files first.An example workflow can be found here: https://github.com/JBlaschke/alcc-recipes/blob/jpb/fireworks/fireworks/test_3_python/fw.py#L26 where a python script manages a 2-node and a 4-node slurm job. In this case
fworker_1, andfworker_2need to be passed to the slurm script in addition tolaunchpad. With the addition of a--jsonflag, this can be handled from the command line without needing to manage additional files.Tagging @lastephey and @computron