creating dick with sorted variables#3395
creating dick with sorted variables#3395dianahorban477-bot wants to merge 2 commits intomate-academy:masterfrom
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job setting up the required dictionary and classifying most of the variables correctly. However, one of the variables is in the wrong category, which is a core requirement of this task.
The profile_info variable is a tuple, which is an immutable data type in Python. It has been incorrectly placed in the "mutable" list. Please move profile_info to the "immutable" list to fix this.
Once that change is made, your solution should meet all the requirements. Keep up the good work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
app/main.py
Outdated
| sorted_variables={"mutable": [my_favourite_films, profile_info, marks, collection_of_coins], | ||
| "immutable": [lucky_number, pi, one_is_a_prime_number, name ]} |
There was a problem hiding this comment.
The profile_info variable is a tuple, which is an immutable data type in Python. It should be moved to the "immutable" list.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this iteration! I am approving your solution. You've successfully addressed the feedback from the previous review by correctly classifying the profile_info variable as immutable. The code now perfectly aligns with all the task requirements. Well done!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.