Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
You've done a great job identifying which variables are mutable and immutable. However, this solution requires a change because the task specifically requires the dictionary values to be lists, but your code currently creates tuples. In Python, using comma-separated values like var1, var2 creates a tuple. To create a list as required, you need to enclose the variables in square brackets: [var1, var2]. Please update both the "mutable" and "immutable" values in your dictionary to use the correct list syntax.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
app/main.py
Outdated
| collection_of_coins = {1, 2, 25} | ||
|
|
||
| # write your code here | ||
| mutable_items = my_favourite_films, marks, collection_of_coins |
There was a problem hiding this comment.
This syntax creates a tuple, but the task requires a list. Remember to use square brackets ([]) to create a list.
app/main.py
Outdated
|
|
||
| # write your code here | ||
| mutable_items = my_favourite_films, marks, collection_of_coins | ||
| immutable_items = lucky_number, pi, one_is_a_prime_number, name, profile_info |
There was a problem hiding this comment.
Similar to the mutable_items, this variable is also a tuple instead of the required list.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this task! I'm happy to approve your solution. You've successfully addressed the previous feedback by using lists for the dictionary values, which is exactly what was needed. The code now correctly sorts all variables into the mutable and immutable categories and fully meets all the requirements. Well done!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.