Skip to content

Improve API errors#4652

Draft
Leo-Besancon wants to merge 2 commits intomainfrom
improve_api
Draft

Improve API errors#4652
Leo-Besancon wants to merge 2 commits intomainfrom
improve_api

Conversation

@Leo-Besancon
Copy link
Copy Markdown
Member

@Leo-Besancon Leo-Besancon commented Feb 22, 2024

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

Notes:

  • We kept the same behaviour as with send_operation, that if one request is invalid in the Vec of requests, then the whole call throws.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 22, 2024

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 71.78%. Comparing base (df156f3) to head (2ca579c).
⚠️ Report is 60 commits behind head on main.

Files with missing lines Patch % Lines
massa-api/src/public.rs 90.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4652   +/-   ##
=======================================
  Coverage   71.78%   71.78%           
=======================================
  Files         291      291           
  Lines       51642    51642           
=======================================
  Hits        37069    37069           
  Misses      14573    14573           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve caller_address usage in read_only API Throw an error when sender does not exists on the ledger

2 participants