Skip to content

emit event when an execution succeeds#4400

Open
modship wants to merge 3 commits intomainfrom
event_execution
Open

emit event when an execution succeeds#4400
modship wants to merge 3 commits intomainfrom
event_execution

Conversation

@modship
Copy link
Copy Markdown
Member

@modship modship commented Sep 11, 2023

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

#4264

@modship modship requested a review from damip September 11, 2023 14:20
@damip
Copy link
Copy Markdown
Member

damip commented Sep 11, 2023

thanks for the update, let's block it for now, until we prioritize things post-testnet

@damip damip added the blocked Issues that can't be done for now. label Sep 11, 2023
@Leo-Besancon Leo-Besancon changed the base branch from main to securnet_wip November 6, 2023 15:02
@Leo-Besancon Leo-Besancon changed the base branch from securnet_wip to buildnet_wip November 8, 2023 15:08
@Leo-Besancon Leo-Besancon changed the base branch from buildnet_wip to pre_mainnet_wip November 28, 2023 08:41
Base automatically changed from pre_mainnet_wip to main May 28, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked Issues that can't be done for now.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants