Skip to content

fix: add back support for Python 3.9#71

Merged
masci merged 2 commits intomasci:mainfrom
yuqi1129:issue_70
Feb 17, 2026
Merged

fix: add back support for Python 3.9#71
masci merged 2 commits intomasci:mainfrom
yuqi1129:issue_70

Conversation

@yuqi1129
Copy link
Copy Markdown
Contributor

This pull request introduces two main changes: it updates the test matrix in the GitHub Actions workflow to include Python 3.9, and it adds the from __future__ import annotations import to several filter modules. These updates improve compatibility with older Python versions and prepare the codebase for future Python enhancements.

Copilot AI review requested due to automatic review settings February 16, 2026 09:34
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Restores Python 3.9 compatibility by ensuring CI runs against 3.9 and by making filter modules safe to import on 3.9 when using PEP 604-style type hints (e.g., str | bytes).

Changes:

  • Add Python 3.9 to the GitHub Actions test matrix for Linux/macOS/Windows.
  • Add from __future__ import annotations to filter modules that use X | Y type annotations to prevent runtime evaluation errors on Python 3.9.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/banks/filters/video.py Postpone annotation evaluation to keep `str
src/banks/filters/image.py Same: adds future import to support PEP 604 union hints on 3.9.
src/banks/filters/document.py Same: adds future import to avoid runtime type-evaluation issues on 3.9.
src/banks/filters/audio.py Same: adds future import to support PEP 604 union hints on 3.9.
.github/workflows/test.yml Expands CI matrix to include Python 3.9 across all OS jobs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@masci masci self-requested a review February 17, 2026 10:45
@masci masci changed the title fix: add back fordward support for Python 3.9 fix: add back support for Python 3.9 Feb 17, 2026
@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 94.763% (+0.02%) from 94.742%
when pulling 0930452 on yuqi1129:issue_70
into 05ff553 on masci:main.

@masci masci linked an issue Feb 17, 2026 that may be closed by this pull request
@masci masci merged commit 66d9e19 into masci:main Feb 17, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The new release version 2.4.0 does not support Python 2.9.x

4 participants