Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Restores Python 3.9 compatibility by ensuring CI runs against 3.9 and by making filter modules safe to import on 3.9 when using PEP 604-style type hints (e.g., str | bytes).
Changes:
- Add Python 3.9 to the GitHub Actions test matrix for Linux/macOS/Windows.
- Add
from __future__ import annotationsto filter modules that useX | Ytype annotations to prevent runtime evaluation errors on Python 3.9.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/banks/filters/video.py |
Postpone annotation evaluation to keep `str |
src/banks/filters/image.py |
Same: adds future import to support PEP 604 union hints on 3.9. |
src/banks/filters/document.py |
Same: adds future import to avoid runtime type-evaluation issues on 3.9. |
src/banks/filters/audio.py |
Same: adds future import to support PEP 604 union hints on 3.9. |
.github/workflows/test.yml |
Expands CI matrix to include Python 3.9 across all OS jobs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
masci
requested changes
Feb 16, 2026
masci
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces two main changes: it updates the test matrix in the GitHub Actions workflow to include Python 3.9, and it adds the
from __future__ import annotationsimport to several filter modules. These updates improve compatibility with older Python versions and prepare the codebase for future Python enhancements.