Allow the app-svc feature to detect when it is actually in gecko.#94
Merged
martinthomson merged 1 commit intomartinthomson:mainfrom Mar 13, 2026
Merged
Conversation
This means that the app-services crates can be built in mozilla-central without requiring any changes.
5 tasks
mhammond
commented
Mar 13, 2026
| } | ||
|
|
||
| flags = BINDGEN_SYSTEM_FLAGS | ||
| let mut flags: Vec<String> = BINDGEN_SYSTEM_FLAGS |
Contributor
Author
There was a problem hiding this comment.
I noticed this build warning in app-services - it would also exist in m-c, but either gets lost in the noise or possibly even omitted entirely.
martinthomson
approved these changes
Mar 13, 2026
Owner
|
Do you need a release for this, or are you ok pulling a git commit hash? |
Contributor
Author
|
Thanks! I'm fine pulling a hash |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This means that the app-services crates can be built in mozilla-central without requiring any changes.
It will help us with migrating app-services to mozilla-central. For this to work, app-services will need mozilla/application-services#7269.
cc @moztcampbell