Add id field to Videos interface#262
Open
tylerbrostrom wants to merge 1 commit intomarkhuot:masterfrom
tylerbrostrom:bro-strummer-patch-1
Open
Add id field to Videos interface#262tylerbrostrom wants to merge 1 commit intomarkhuot:masterfrom tylerbrostrom:bro-strummer-patch-1
tylerbrostrom wants to merge 1 commit intomarkhuot:masterfrom
tylerbrostrom:bro-strummer-patch-1
Conversation
This pull request simply adds the [`id` property from the `Video` model](https://docs.dukt.net/videos/v2/video-model.html#id) as an integer field on the `Videos` interface. Adding this field might help those directly using the Vimeo player SDK or some player component, like [vue-vimeo-player](https://www.npmjs.com/package/vue-vimeo-player).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Mark 👋
This pull request simply adds the
idproperty from theVideomodel as an integer field on theVideosinterface.Adding this field might help those directly using the Vimeo player SDK or some abstraction on top of it, like vue-vimeo-player.