Use upstream signature formatting code for pylsp#5214
Merged
mscolnick merged 2 commits intomarimo-team:mainfrom Jul 10, 2025
Merged
Use upstream signature formatting code for pylsp#5214mscolnick merged 2 commits intomarimo-team:mainfrom
mscolnick merged 2 commits intomarimo-team:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
for more information, see https://pre-commit.ci
mscolnick
approved these changes
Jun 9, 2025
Contributor
Author
|
Kicking CI now that https://github.com/python-lsp/python-lsp-server/releases/tag/v1.13.0 is released |
mscolnick
approved these changes
Jul 10, 2025
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.14.11-dev48 |
Light2Dark
pushed a commit
that referenced
this pull request
Jul 14, 2025
## 📝 Summary This is a follow-up to #4864 since the signature-formatting capability was incorporated directly into `python-lsp-server` ## 🔍 Description of Changes Removed custom plugin and typechecking dependency on `python-lsp-server`, added configuration to prefer `ruff` if enabled over `black` (default in `python-lsp-server`). This should remain in draft pending a new release of `python-lsp-server`. ## 📋 Checklist - [x] I have read the [contributor guidelines](https://github.com/marimo-team/marimo/blob/main/CONTRIBUTING.md). - [ ] For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on [Discord](https://marimo.io/discord?ref=pr), or the community [discussions](https://github.com/marimo-team/marimo/discussions) (Please provide a link if applicable). - [ ] I have added tests for the changes made. - [ ] I have run the code and verified that it works as expected. ## 📜 Reviewers mscolnick --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
sebbeutler
pushed a commit
to sebbeutler/marimo
that referenced
this pull request
Jul 16, 2025
## 📝 Summary This is a follow-up to marimo-team#4864 since the signature-formatting capability was incorporated directly into `python-lsp-server` ## 🔍 Description of Changes Removed custom plugin and typechecking dependency on `python-lsp-server`, added configuration to prefer `ruff` if enabled over `black` (default in `python-lsp-server`). This should remain in draft pending a new release of `python-lsp-server`. ## 📋 Checklist - [x] I have read the [contributor guidelines](https://github.com/marimo-team/marimo/blob/main/CONTRIBUTING.md). - [ ] For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on [Discord](https://marimo.io/discord?ref=pr), or the community [discussions](https://github.com/marimo-team/marimo/discussions) (Please provide a link if applicable). - [ ] I have added tests for the changes made. - [ ] I have run the code and verified that it works as expected. ## 📜 Reviewers mscolnick --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
This is a follow-up to #4864 since the signature-formatting capability was incorporated directly into
python-lsp-server🔍 Description of Changes
Removed custom plugin and typechecking dependency on
python-lsp-server, added configuration to preferruffif enabled overblack(default inpython-lsp-server).This should remain in draft pending a new release of
python-lsp-server.📋 Checklist
📜 Reviewers
mscolnick