Skip to content

Revert "fix: cleanup empty file"#165

Merged
phil-abb merged 1 commit intopre-draftfrom
revert-file-removal
Mar 17, 2026
Merged

Revert "fix: cleanup empty file"#165
phil-abb merged 1 commit intopre-draftfrom
revert-file-removal

Conversation

@Silvanoc
Copy link
Copy Markdown
Contributor

@Silvanoc Silvanoc commented Mar 17, 2026

This reverts commit 8874979.

Description

Apparently that empty file was needed. Restoring it.

Issues Addressed

Change Type

Please select the relevant options:

  • Fix (change that resolves an issue)
  • New enhancement (change that adds specification content)
  • Content edits (change that edits existing content)

Checklist

  • I have read the CONTRIBUTING document.
  • My changes adhere to the established patterns, and best practices.

@Silvanoc Silvanoc requested a review from a team as a code owner March 17, 2026 12:47
@github-actions
Copy link
Copy Markdown

@Silvanoc the signed-off-by was not found in the following 1 commits:

  • 338a2ad: Revert "fix: cleanup empty file"

📝 What should I do to fix it?

All proposed commits should include a sign-off in their messages, ideally at the end.

❔ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO, reformatted for readability:

By making a contribution to this project, I certify that:

a. The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

b. The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

c. The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

d. I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <randomdeveloper@example.com>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

@Silvanoc Silvanoc mentioned this pull request Mar 17, 2026
5 tasks
@Silvanoc Silvanoc requested a review from phil-abb March 17, 2026 12:51
Copy link
Copy Markdown
Contributor

@ajcraig ajcraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quick fix.

@phil-abb
Copy link
Copy Markdown
Contributor

@Silvanoc, unfortunately, your commit isn't signed off on, so validation rules are failing.

@Silvanoc
Copy link
Copy Markdown
Contributor Author

Thanks for quick fix.

I don't like to have my own mess lying around 😄

@Silvanoc
Copy link
Copy Markdown
Contributor Author

Silvanoc commented Mar 17, 2026

@Silvanoc, unfortunately, your commit isn't signed off on, so validation rules are failing.

Reverts are typically not signed-off, because nothing new is being created and the sign-off is only about authorship of the code. But I can rewrite the commit to add a sign-off, if needed.

I've seen the comment, but since the pipeline was green, I've considered that the validation rules are succeeding.

@phil-abb phil-abb merged commit b90bc72 into pre-draft Mar 17, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants