Implement Dark Mode for explanation.show_in_notebook method#728
Open
ajwells128 wants to merge 1 commit intomarcotcr:masterfrom
Open
Implement Dark Mode for explanation.show_in_notebook method#728ajwells128 wants to merge 1 commit intomarcotcr:masterfrom
ajwells128 wants to merge 1 commit intomarcotcr:masterfrom
Conversation
ajwells128
commented
Aug 1, 2023
| if (dark_mode): | ||
| out = out.replace("\"black\"", "\"white\"") | ||
| out = out.replace("all: initial;", "all: initial; color: white;") | ||
| out = re.sub(r"svg.append\('text(((?!fill).)*);", r"svg.append('text\1.style('fill', 'white');", out) |
Author
There was a problem hiding this comment.
This regex finds all svg texts (which don't adhere to any css or html color styling) for which a color is not specified (to avoid touching the purposefully colorful words) and decorates them with another style (fill: white)
|
So is this resolved or not @ajwells128 ? |
Author
The PR is still open and has been unreviewed as far as I know. The code worked just fine last I checked it, not sure if any changes have been made since then. I don't have permission to merge the PR, though. If you are interested in benefitting from dark mode yourself before the PR merges, you can install the package in the usual way and then make these changes to the library files if you wish. |
|
hello
what's this about?
…________________________________
From: ajwells128 ***@***.***>
Sent: 20 December 2023 14:40
To: marcotcr/lime ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [marcotcr/lime] Implement Dark Mode for explanation.show_in_notebook method (PR #728)
So is this resolved or not @ajwells128<https://github.com/ajwells128> ?
The PR is still open and has been unreviewed as far as I know. The code worked just fine last I checked it, not sure if any changes have been made since then. I don't have permission to merge the PR, though. If you are interested in benefitting from dark mode yourself before the PR merges, you can install the package in the usual way and then make these changes to the library files if you wish.
—
Reply to this email directly, view it on GitHub<#728 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/APH5BTK54AUXITSPKYX2Y5TYKL2HLAVCNFSM6AAAAAA3AFGJMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRUGU4DQNRQG4>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement dark mode for explanation.show_in_notebook method by post-processing the formatted HTML.
Without this, in a notebook that is rendered in dark mode, the text is scarcely legible.
Example (from tutorial):
