Add config option default_chmod to be applied after file creation#267
Open
mrtati wants to merge 1 commit intomarcosnils:masterfrom
Open
Add config option default_chmod to be applied after file creation#267mrtati wants to merge 1 commit intomarcosnils:masterfrom
mrtati wants to merge 1 commit intomarcosnils:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have an unusual umask setup and so the file created was not as expected. Also the default mask value of 0766 was not ideal for me.
I added a new config option
default_chmodwhich is applied explicitly as chmod after file creation.The default value is automatically set to 0766 as it was in the code already, so no apparent change in functionality if this config value is not changed.