Use a range for CMake minimum versions, 3.2...3.12: support CMake 4.0#121
Use a range for CMake minimum versions, 3.2...3.12: support CMake 4.0#121musicinmybrain wants to merge 1 commit intomapbox:masterfrom
Conversation
|
Thanks for the heads up. But since we don't need any newer features, I think we should only advance to 3.5 if that's what cmake still supports. Also the README.md would probably need a small update for the required cmake version. |
Ok, adjusted on both counts and force-pushed. Looking back at Lines 27 to 30 in 7fa7aa3 Lines 37 to 40 in 7fa7aa3 |
|
I’m going to update this again to set a minimum version range, |
CMake 4.0 drops support for CMake <3.5, so minimum versions need to be adjusted for forward compatibility. Since CMake <3.10 is already deprecated, and 3.12 is the first “modern” CMake release, let’s support policy versions up to 3.12. https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html
|
Sorry to bump, but it would be nice to get this merged so it can used with CMake 4.0. |
|
Thanks for the PR! Superceded by #128 |
CMake 4.0 drops support for CMake <3.5, so minimum versions need to be adjusted for forward compatibility.
As long as we are touching the minimum version, let’s advance to 3.12, which can be considered the oldest “modern” CMake release, and which is available in all known supported Linux distributions today.