Open
Conversation
|
|
Linux debug test results 8 files 8 suites 13m 19s ⏱️ Results for commit 2eff35c. ♻️ This comment has been updated with latest results. |
Linux release test results 8 files 8 suites 6m 32s ⏱️ Results for commit 2eff35c. ♻️ This comment has been updated with latest results. |
Windows test results 5 files 5 suites 18m 26s ⏱️ Results for commit 2eff35c. ♻️ This comment has been updated with latest results. |
sanikolaev
requested changes
Mar 21, 2026
Collaborator
sanikolaev
left a comment
sanikolaev
left a comment
There was a problem hiding this comment.
There seems to be a crash revealed by the CLT tests. We need to look into that.
Related issues: - manticoresoftware/manticoresearch#3771 - manticoresoftware/manticoresearch#3869 The EmbedLib struct layout changed which is a breaking change in the embeddings library. Additional changes: - Added git commit ID and timestamp to the build process for consistent versioning across libraries. - Moved API key validation to CREATE TABLE. - Improved error handling for remote model requests, including detailed HTTP error reporting. - Updated tests to reflect changes in API key validation and model initialization.
- api_timeout=0 now means unlimited instead of 10s default - Jina, OpenAI, Voyage models accept None for no timeout - Update FFI test with api_url parameter
- Apply consistent multi-line formatting to error enum variants - Simplify timeout duration mapping using Option::map - Remove redundant match expressions in model constructors
donhardman
force-pushed
the
api_url_timeout_rebased
branch
from
0d20a15 to
2eff35c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.