[WIP] Fix http client method usage based on feedback#94
Merged
manthanabc merged 2 commits intoqwenfrom Feb 15, 2026
Merged
Conversation
Open
Co-authored-by: manthanabc <48511543+manthanabc@users.noreply.github.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Pull request overview
This PR simplifies Qwen OAuth HTTP logic by removing an unnecessary HTTP client wrapper and using the shared build_http_client helper directly for device-code and token polling requests.
Changes:
- Replace
build_http_client_internalusage with direct calls tobuild_http_client(...) - Remove the now-redundant
build_http_client_internalhelper from the Qwen HTTP provider
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build_http_client_internalwrapper methodrequest_device_codeto callbuild_http_clientdirectlypoll_for_tokento callbuild_http_clientdirectly💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.