Skip to content

Fix canvas z-index and right sidebar overflow into menubar #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manthanabc merged 2 commits into from
Feb 22, 2026
Merged

Fix canvas z-index and right sidebar overflow into menubar #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0cea354
Initial plan
Copilot Feb 22, 2026
d153c10
Fix canvas z-index and right sidebar overlap with menubar
Copilot Feb 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/routes/(components)/overlay/RightMenu.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

</script>

<div class="absolute right-1 h-full flex flex-col justify-end pointer-events-none">
<div class="absolute right-1 top-16 bottom-0 flex flex-col justify-end pointer-events-none">
Copy link

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

top-16 bottom-0 reduces the available sidebar height, but with flex-col justify-end the sidebar can still overflow upward when its contents are taller than the available space (the overflow will simply extend above top-16). To actually prevent overlap into the menubar in the “content exceeds viewport” case, consider making the sidebar region scrollable (e.g., overflow-y-auto) and/or changing the layout so only the bottom element is anchored (e.g., use mt-auto on the bottom section instead of justify-end).

Copilot uses AI. Check for mistakes.

<DFATable />
<HelpMenu />
Expand Down
4 changes: 2 additions & 2 deletions src/routes/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@
</script>

<div class="ts-app-surface flex flex-col items-stretch overflow-hidden">
<Overlay />

<canvas id="DFA" class="ts-canvas" tabindex="0"></canvas>

<Overlay />

Comment on lines 35 to +38
Copy link

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving <canvas> before <Overlay /> changes keyboard tab order so the canvas will receive focus before the overlay controls (buttons, textarea, etc.). If the intent is only visual stacking, consider keeping the DOM order and instead adjust stacking via CSS (e.g., place the overlay in a higher stacking context / z-index) or remove the canvas from the tab order if it shouldn’t be first-focusable.

Suggested change
<canvas id="DFA" class="ts-canvas" tabindex="0"></canvas>
<Overlay />
<Overlay />
<canvas id="DFA" class="ts-canvas" tabindex="0"></canvas>

Copilot uses AI. Check for mistakes.
<SpotifyEmbed />
<Popup />
</div>