Open
Conversation
…ectionExplorer component - Added `fetchTableSchema` query parameter to the API, allowing users to control whether per-table column metadata is loaded. - Updated the ConnectionExplorer component to use a new state management approach for selected tables, improving clarity and functionality. - Refactored the TableSchemaViewer and introduced a new SelectedTableDetailPanel for better separation of concerns and enhanced loading state handling. - Adjusted API documentation to reflect the new query parameter and its behavior. These changes improve the user experience by providing more control over data fetching and enhancing the component structure for maintainability. Signed-off-by: Sagar Swami Rao Kulkarni <sagarswamirao@gmail.com>
- Updated the version of `@malloydata/malloy-interfaces` in package.json and bun.lock to "^0.0.368". - Increased the versions of various `@malloydata` database packages in bun.lock and server package.json to "^0.0.368". These changes ensure compatibility with the latest updates and improvements in the Malloy data packages. Signed-off-by: Sagar Swami Rao Kulkarni <sagarswamirao@gmail.com>
- Updated the SQL query in the listTablesForSchema function to use `SHOW TABLES IN SCHEMA ${schemaName}` for better compatibility with Snowflake.
- Enhanced logging to include debug information about listed tables.
- Improved the mapping of result rows to ensure proper handling of table names, accommodating variations in casing.
These changes enhance the functionality and maintainability of the database utility functions.
Signed-off-by: Sagar Swami Rao Kulkarni <sagarswamirao@gmail.com>
- Changed the default value of a boolean parameter from `false` to `true` in the API documentation for improved clarity on expected behavior. This update ensures that users have accurate information regarding the default settings when interacting with the API. Signed-off-by: Sagar Swami Rao Kulkarni <sagarswamirao@gmail.com>
…nsistency - Removed an unnecessary boolean parameter from the SelectedTableDetailPanel function. - Adjusted the formatting of conditional checks in the TableSchemaViewer and TablesInSchema functions for better clarity. - Enhanced the overall structure of the code to maintain consistency in style and improve maintainability. These changes contribute to a cleaner codebase and enhance the readability of the ConnectionExplorer component. Signed-off-by: Sagar Swami Rao Kulkarni <sagarswamirao@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.