Draft
Conversation
- Enhanced the `testConnectionConfig` function to handle DuckLake connections using an in-memory DuckDB instance, improving testing efficiency without creating persistent files. - Added error handling for missing DuckLake connection configurations. - Streamlined the connection testing process for DuckDB and other connection types, ensuring clearer error messages and improved maintainability. - Removed unnecessary cleanup for DuckLake files during testing. These changes improve the robustness and clarity of the connection testing functionality. Signed-off-by: Sagar Swami Rao Kulkarni <sagarswamirao@gmail.com>
- Optimized the `getSchemasForConnection` function to reduce API calls by directly returning dataset information without fetching metadata, improving performance. - Enhanced the `Model` class to defer source info extraction until explicitly requested, reducing initial load times and improving memory management. - Updated the `Package` class to utilize a shared DuckDB connection for database info retrieval, minimizing redundant connections and improving efficiency. - Improved error handling in the `ProjectStore` class to provide clearer messages and ensure proper resource cleanup during initialization failures. These changes enhance performance, maintainability, and error handling across the database and model management functionalities. Signed-off-by: Sagar Swami Rao Kulkarni <sagarswamirao@gmail.com>
- Simplified the schema mapping logic by replacing asynchronous metadata retrieval with a synchronous mapping, improving performance and readability. - Removed unnecessary error logging related to DuckLake connection parameters in listTablesForSchema function. These changes enhance the efficiency of schema handling and clean up the codebase. Signed-off-by: Sagar Swami Rao Kulkarni <sagarswamirao@gmail.com>
…publisher into sagark/optimizations Signed-off-by: Sagar Swami Rao Kulkarni <sagarswamirao@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.