Draft
Conversation
- Removed the installation of DuckDB bindings from the build command in package.json. - Updated Bun version from 1.2.23 to 1.3.10 in multiple GitHub Actions workflows to ensure compatibility and leverage new features. - Refactored E2E test setup by consolidating environment variable handling and improving server readiness checks, enhancing reliability during tests. These changes streamline the build process and improve the testing environment's robustness. Signed-off-by: Sagar Swami Rao Kulkarni <sagarswamirao@gmail.com>
- Increased the thresholds for `http_req_duration` and `http_req_waiting` in both load-test.ts and smoke-test.ts to accommodate higher response times, ensuring tests reflect realistic performance expectations. - Adjusted specific request duration thresholds for `post_query_data` and `execute_query` to improve accuracy in performance monitoring. These changes enhance the reliability of performance testing by aligning thresholds with expected application behavior. Signed-off-by: Sagar Swami Rao Kulkarni <sagarswamirao@gmail.com>
- Added a no-op metrics handler for test environments to prevent errors when Prometheus exporter is not initialized. - Implemented logic to skip OpenTelemetry instrumentation in test environments, reducing initialization issues. - Updated logger middleware to skip logging for proxied requests in development mode, minimizing log noise. These changes improve the handling of metrics and logging during testing, ensuring a smoother development experience. Signed-off-by: Sagar Swami Rao Kulkarni <sagarswamirao@gmail.com>
- Updated the no-op metrics handler in the instrumentation module to use a more concise parameter naming convention, changing `req` to `_req` to indicate that the request object is unused. This change enhances code clarity and maintains consistency in handling unused parameters in the codebase. Signed-off-by: Sagar Swami Rao Kulkarni <sagarswamirao@gmail.com>
- Replaced the use of `fail` with a more explicit `throw new Error` to indicate promise rejection due to cancellation in the MCP Tool integration tests. - Removed unused import of `fail` from the test file, streamlining the code. These changes improve clarity in error handling and enhance the maintainability of the test suite. Signed-off-by: Sagar Swami Rao Kulkarni <sagarswamirao@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.