Skip to content

telemetry/geoprobe: use per-probe TWAMP port and change geoprobe default from 862 to 8925#3218

Merged
ben-dz merged 1 commit intomainfrom
bdz/geolocation-twamp-port-changes
Mar 9, 2026
Merged

telemetry/geoprobe: use per-probe TWAMP port and change geoprobe default from 862 to 8925#3218
ben-dz merged 1 commit intomainfrom
bdz/geolocation-twamp-port-changes

Conversation

@ben-dz
Copy link
Contributor

@ben-dz ben-dz commented Mar 9, 2026

Summary of Changes

  • DZD ACL policies block TWAMP replies on port 862 from geoprobe-agents. Change the geoprobe-agent and geoprobe-target default TWAMP reflector port from 862 to 8925, and make the pinger use a per-probe TWAMP port instead of a hardcoded constant.
  • Add TWAMPPort field to ProbeAddress so each probe carries both its UDP offset port and TWAMP reflector port.
  • Update ParseProbeAddresses to accept host (defaults both ports to 8923/8925) or host:offset_port:twamp_port (both explicit). The old two-field host:port format is rejected as ambiguous.
  • Device-to-device TWAMP (port 862) and controller ACL templates are unaffected.

Diff Breakdown

Category Files Lines (+/-) Net
Core logic 4 +56 / -20 +36
CLI/config 3 +4 / -4 0
Tests 4 +159 / -91 +68

Most of the diff is mechanical test updates adding TWAMPPort: 8925 to ProbeAddress literals.

Key files (click to expand)

@ben-dz ben-dz force-pushed the bdz/geolocation-twamp-port-changes branch from 56319cd to 698c912 Compare March 9, 2026 22:00
…nd DZD ACLs. also make it configurable to get around any further problems without new binaries.
@ben-dz ben-dz force-pushed the bdz/geolocation-twamp-port-changes branch from 698c912 to ff28de9 Compare March 9, 2026 22:17
@ben-dz ben-dz marked this pull request as ready for review March 9, 2026 22:17
@ben-dz ben-dz enabled auto-merge (squash) March 9, 2026 22:17
@ben-dz ben-dz merged commit 61548aa into main Mar 9, 2026
30 checks passed
@ben-dz ben-dz deleted the bdz/geolocation-twamp-port-changes branch March 9, 2026 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants