Draft
Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements version 11 of the wl_seat protocol, specifically adding support for the wl_keyboard.frame event. This event is used to group related keyboard events together, allowing clients to batch-process keyboard state changes for better efficiency.
Key changes:
- Added frame event to the wire protocol definition for wl_keyboard (version 11)
- Implemented frame event batching mechanism using an async queue
- Updated all keyboard event methods to schedule frame events appropriately
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| wire/wl_keyboard.txt | Adds the frame event definition for protocol version 11 |
| src/state.rs | Adds keyboard_frames queue for async frame event handling |
| src/compositor.rs | Initializes keyboard_frames queue and spawns the async frame handler |
| src/ifs/wl_seat/wl_keyboard.rs | Implements frame event batching, adds version/client fields, updates all event methods to use new batching mechanism |
| src/ifs/wl_seat/zwp_virtual_keyboard_v1.rs | Updates signature to use Rc instead of reference |
| src/ifs/wl_seat.rs | Bumps wl_seat global version from 10 to 11 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mahkoh
force-pushed
the
jorth/seat-v-11
branch
from
ae3ac3f to
23b897b
Compare
mahkoh
force-pushed
the
jorth/seat-v-11
branch
from
23b897b to
dd2dd32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://gitlab.freedesktop.org/wayland/wayland/-/merge_requests/500