color-management: implement ext-image-capture-color-management-v1#616
Draft
color-management: implement ext-image-capture-color-management-v1#616
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements the ext-image-capture-color-management-v1 protocol extension to provide color management support for image capture operations. It allows clients to specify and retrieve color descriptions for captured frames.
Key changes include:
- Adds new Wayland protocol definitions for color management in image capture
- Implements color description tracking and listeners for surfaces and outputs
- Integrates color descriptions into the image capture frame pipeline
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| wire/*.txt | Protocol definitions for color management interfaces |
| src/ifs/ext_image_copy/ext_image_capture_color_manager_v1.rs | Main color manager implementation |
| src/ifs/ext_image_capture_source_colors_v1.rs | Source color tracking and event handling |
| src/ifs/color_management/wp_image_description_reference_v1.rs | Reference object for image descriptions |
| src/ifs/ext_image_copy/ext_image_copy_capture_frame_v1.rs | Frame color description integration |
| src/ifs/wl_surface.rs | Surface color description listener support |
| src/ifs/wl_output.rs | Output color description listener support |
| src/client/objects.rs | Object storage for new types |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
3497ecf to
1148d01
Compare
1148d01 to
12da187
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requests/448