Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #361 +/- ##
==========================================
+ Coverage 47.30% 48.39% +1.08%
==========================================
Files 327 338 +11
Lines 58572 63251 +4679
==========================================
+ Hits 27710 30608 +2898
- Misses 27804 29202 +1398
- Partials 3058 3441 +383 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces new functionality and tests for the
advnpackage, focusing on improved JSON marshaling/unmarshaling, time formatting options, and expanded test coverage for ECharts and PNG output. The changes add robust JSON handling, flexible output time formatting, and comprehensive tests for ECharts and PNG rendering logic.New Features and Enhancements:
Spec,Series, andDomain, along with utility functions for parsing and validating JSON input (jsh/advn/json.go).OutputTimeOptionsand related logic for formatting and encoding time values with support for time zones and multiple formats, improving ECharts output flexibility (jsh/advn/output_time.go).Testing Improvements:
jsh/advn/echarts_test.go).jsh/advn/png_test.go).Dependency Updates:
golang.org/x/imagefrom an indirect to a direct dependency ingo.modto support new image processing requirements. [1] [2]