Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #360 +/- ##
==========================================
- Coverage 46.35% 46.34% -0.01%
==========================================
Files 325 326 +1
Lines 57945 58356 +411
==========================================
+ Hits 26859 27047 +188
- Misses 28095 28308 +213
- Partials 2991 3001 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for advanced stderr redirection in the shell parser and execution engine, and introduces more flexible process execution options. The most important changes include support for
2>,2>>, and2>&1redirection operators, a newExecOptionsstruct for customizing process I/O, and direct implementations of internal shell commands. Comprehensive tests are added to ensure correctness.Shell parser and redirection support:
2>,2>>, and2>&1stderr redirection operators in the shell parser, allowing commands to redirect or merge stderr as in typical Unix shells. [1] [2] [3] [4]parser_test.goto cover new stderr redirection features and tokenization. [1] [2] [3]Engine execution options:
ExecOptionsstruct to allow callers to specify customStdin,Stdout, andStderrstreams when executing commands, and addedExecWithOptionsandExecStringWithOptionsmethods toJSRuntime. [1] [2] [3] [4]exec0implementations to use the new options for process I/O redirection. [1] [2]ExecWithOptionsandExecStringWithOptionsto verify custom I/O handling.Internal shell command refactoring:
cd,setenv,unsetenv,which) to be implemented directly in Go, improving error handling and output flexibility.These changes provide more robust and flexible shell command parsing and execution, bringing the shell closer to typical Unix shell behavior.