DM-54529: Fix broken logic in PsfWcsSelectImagesTask#1288
Merged
Conversation
arunkannawadi
approved these changes
Apr 2, 2026
| starUnNormalizedEMedian = row["starUnNormalizedEMedian"] | ||
|
|
||
| valid = True | ||
| # The logic of this condition does not follow the ones below. Isolating |
Member
There was a problem hiding this comment.
I don't like the phrasing of "The logic of this condition does not follow the ones below". I'd suggest removing that, but not strongly enough to request changes.
Contributor
Author
There was a problem hiding this comment.
Do you have a suggestion for wording that would sit well with you? I feel strongly about noting this difference in hopes that this won't get missed again.
Member
There was a problem hiding this comment.
Something along the lines of "We check for this condition upfront", and may be reference the ticket for context later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.