DM-53212: Add functions for getting full ccdVisit table and wide quicklook table

[mfisherlevine]

No description provided.

[TallJimbo]

I'm a little surprised you're doing this join with astropy instead of SQL.

[bbrondel]

I really think it makes more sense to do this join with SQL.

[mfisherlevine]

Looks like I can replace this with

vqCols = set(client.query("SELECT * FROM cdb_LSSTCam.visit1_quicklook LIMIT 0").colnames)
vCols = set(client.query("SELECT * FROM cdb_LSSTCam.visit1 LIMIT 0").colnames)

vOnlyCols = vCols - vqCols  # exclude visit_id and all duplicates

selectClauses = ["vq.*"] + [f"v.{col}" for col in sorted(vOnlyCols)]

query = f"""
    SELECT {', '.join(selectClauses)}
    FROM cdb_LSSTCam.visit1_quicklook vq
    INNER JOIN cdb_LSSTCam.visit1 v USING (visit_id)
    WHERE vq.day_obs = {dayObs}
"""
return client.query(query)

Does that look reasonable to you, or am I still missing tricks?

[mfisherlevine]

And was it just this function, or did you think the other one should have more things moved to SQL too?

[TallJimbo]

That looks good to me, and think it was only this function.