Conversation
Co-authored-by: huacnlee <5518+huacnlee@users.noreply.github.com>
Co-authored-by: huacnlee <5518+huacnlee@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Make a PR to remove wef relative code. Because I have extract it to @longbridge/wef/pull/1
Remove WEF (Web Embedding Framework) code as it has been extracted to separate repository
Sep 29, 2025
huacnlee
changed the title
huacnlee
reviewed
Sep 29, 2025
|
|
||
| ```toml | ||
| gpui-component = { git = "https://github.com/longbridge/gpui-component.git", features = ["webview"] } | ||
| ``` |
Contributor
Author
There was a problem hiding this comment.
You're absolutely right! I've restored the WebView documentation section. The wry-based WebView functionality in the UI crate is separate from WEF and should remain available. Restored in commit 7b5efd1.
Member
|
@copilot And the |
Co-authored-by: huacnlee <5518+huacnlee@users.noreply.github.com>
Co-authored-by: huacnlee <5518+huacnlee@users.noreply.github.com>
Contributor
Author
Updated the CI configuration to remove all WEF-related steps including CEF_VERSION environment variable, CEF caching, WEF initialization, and cargo-wef commands. The CI now runs clean tests without WEF dependencies. Fixed in commit 5a3bbdd. |
huacnlee
deleted the
copilot/fix-d5e2c3d9-f280-4f6d-8343-63423394a6fe
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All WEF (Web Embedding Framework) related code has been successfully removed from the repository as it has been extracted to https://github.com/longbridge/wef