Skip to content

Change methods not using its bound instance to staticmethods #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deepsource-autofix wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change methods not using its bound instance to staticmethods #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions personalBestCache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ class cacheMiss(Exception):
pass

class personalBestCache:
def get(self, userID, fileMd5, country=False, friends=False, mods=-1):
@staticmethod
def get(userID, fileMd5, country=False, friends=False, mods=-1):
"""
Get cached personal best rank

Expand Down Expand Up @@ -42,7 +43,8 @@ def get(self, userID, fileMd5, country=False, friends=False, mods=-1):
log.debug("personalBestCache miss")
return 0

def set(self, userID, rank, fileMd5, country=False, friends=False, mods=-1):
@staticmethod
def set(userID, rank, fileMd5, country=False, friends=False, mods=-1):
"""
Set userID's redis personal best cache

Expand Down
3 changes: 2 additions & 1 deletion tomejerry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,8 @@ def recycle(self, start: bool=True):
if start:
self.threaded_work()

def recalc_score(self, score_data: Dict) -> score:
@staticmethod
def recalc_score(score_data: Dict) -> score:
"""
Recalculates pp for a score

Expand Down
3 changes: 2 additions & 1 deletion userStatsCache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ def get(self, userID, gameMode):
retData = json.loads(data.decode("utf-8"))
return retData

def update(self, userID, gameMode, data = None):
@staticmethod
def update(userID, gameMode, data = None):
"""
Update cached user stats in redis with new values

Expand Down