Merged
Conversation
JuneRousseau
force-pushed
the
cnull-register
branch
from
a31e2fc to
7c0d9cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR properly implements the
cnullregister, which always contains 0. It fixes the operational semantic by using the following custom maps:(!!ᵣ): special lookup that returnsWInt 0if we lookupcnull.<[ r := w ]ᵣ>: special insert that insertWInt 0if we insertcnull.It implements an extension of the tactic
simplify_map_eqwith the tacticsimpl_map_regs, and preserves as much as possible the proofs of the program logic.