Open
Conversation
Ignore files may be sitting at the top level directory, which prevents the search from coming up with anything. In addition a shortcut was added to check for the package much faster than iterating the entire install tree.
The venv folder was getting placed at the root install folder which basically causes every package in the workspace to overwrite the venv of other packages, last package wins...
Collaborator
Author
|
This has been my pending branch for per package builds as I notice issues. Its fixing two things currently:
The first is fixed by requiring a source directory be passed to the venv tooling which comes from either:
I'm tempted to remove much of the stuff in |
jprestwo
commented
Mar 4, 2026
By passing the source directory as well as using the proper ament API to find the package prefix, searching the env vars with assumed paths isn't reliable or useful anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.