Conversation
Update all examples to use the new lvt testing API: - StartDockerChrome now returns error instead of *exec.Cmd - StopDockerChrome now takes (t, debugPort) instead of (t, cmd, debugPort) This aligns with the latest lvt/testing package changes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates three test files to use the new lvt testing API for Docker Chrome container management. The main change is in the function signatures: StartDockerChrome now returns an error instead of a command object, and StopDockerChrome no longer requires the command object parameter.
Key Changes
- Updated
StartDockerChrometo check for errors instead of capturing a command object - Simplified
StopDockerChromecalls by removing the command object parameter - Added proper error handling with
t.Fatalffor Chrome startup failures
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| avatar-upload/avatar-upload_test.go | Updated Docker Chrome API calls with new error handling pattern |
| counter/counter_test.go | Updated Docker Chrome API calls with new error handling pattern |
| todos/todos_test.go | Updated Docker Chrome API calls with new error handling pattern |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The previous commit assumed the new lvt testing API was published, but the new API (StartDockerChrome returning error, StopDockerChrome taking 2 args) is still unpushed in the local lvt repo. Reverting to the published API: - StartDockerChrome returns *exec.Cmd - StopDockerChrome takes (t, cmd, debugPort) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
avatar-upload,counter, andtodostest filesTest plan
🤖 Generated with Claude Code