Conversation
NOTE: Need a frostbyte73/core PR to merge and tag a release PR pending: frostbyte73/core#5
|
| "queueDuration", time.Since(enqueuedAt), | ||
| ) | ||
| sentStart := time.Now() | ||
| if !n.pool.Submit(n.eventKey(event), func() { |
There was a problem hiding this comment.
This is the needed change to core to get a synchronous return value from Submit if it is successful or not. That will allow logging/posting event for dropped events too.
go.mod
Outdated
| google.golang.org/genproto/googleapis/api v0.0.0-20241202173237-19429a94021a // indirect | ||
| ) | ||
|
|
||
| replace github.com/frostbyte73/core => ../frostbyte73/core/core |
There was a problem hiding this comment.
should we fork these? (this and iters)
There was a problem hiding this comment.
core - we have @frostbyte73 to ping, so maybe can remain there?
iters - are we making changes, if up streaming is delaying things makes sense to fork
There was a problem hiding this comment.
they're both maintained by our people it's just awkward that no one else has write access and applying upstream changes can block landing code here
There was a problem hiding this comment.
oh, is iters from @dennwc , did not realise that, sorry
yeah, would be good to not have that dependency, forking and upstreaming without blocking makes sense.
@frostbyte73 @dennwc @davidzhao okay to fork those into livekit org?
2 participants
NOTE: Need a frostbyte73/core PR to merge and tag a release
PR pending: frostbyte73/core#5